Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): do not react to swipes if draggable is disabled on carousel #9963

Closed
wants to merge 1 commit into from
Closed

fix(kit): do not react to swipes if draggable is disabled on carousel #9963

wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

Fixes #9771

@splincode splincode requested a review from a team as a code owner December 11, 2024 07:27
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 11, 2024 07:27
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 11, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (b94bec5) to head (b114d7e).

Files with missing lines Patch % Lines
...ects/kit/components/carousel/carousel.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9963   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19607           
  Branches     2033     2031    -2     
=======================================
  Hits        14757    14757           
- Misses       4806     4808    +2     
+ Partials       44       42    -2
Flag Coverage Δ
summary 75.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit b114d7e):

https://taiga-previews-demo--pr9963-splincode-fix-issues-9771-pyyaew8f.web.app

(expires Thu, 12 Dec 2024 07:31:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 11, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 303.97KB (+17B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.19KB +10%
✅ demo/browser/runtime.(hash).js
 43.93KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +17B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.38MB (+17B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

Playwright test results

passed  981 passed

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  8 minutes, 55 seconds
commit  b114d7e

@splincode splincode closed this Dec 11, 2024
@splincode splincode deleted the splincode/fix/issues/9771 branch December 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Carousel Component Ignores draggable: false on Mobile Devices
1 participant
@splincode